-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stub nodeService to improve macos devloop #2197
Conversation
Code Coverage DiffThis PR does not change the code coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The code looks good to me, but I do not have a Mac, and the PR description appears to indicate we haven't tested the e2e tests on MacOS.
Given that's the primary purpose of this PR can somebody with a Mac make sure to test at least the single-az and external tests on MacOS before this is approved?
This was done, I have edited PR description from |
Ah, my bad, when you said "running" I thought you meant the CI tests. If they've all passed locally on a Mac, then /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
Developer Experience
What is this PR about? / Why do we need it?
Fixes #1556
EBS CSI Driver does not support MacOS, but contributors may only have a mac development machine. Therefore the project should compile well enough for the typical development loop (e.g. build, running unit and e2e tests).
As issue #1556 puts it "I should be able to run the e2e tests from my laptop without having to jump through hoops."
What testing is done?
make test
and ran e2e tests