Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub nodeService to improve macos devloop #2197

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

AndrewSirenko
Copy link
Contributor

@AndrewSirenko AndrewSirenko commented Oct 25, 2024

Is this a bug fix or adding new feature?
Developer Experience

What is this PR about? / Why do we need it?
Fixes #1556

EBS CSI Driver does not support MacOS, but contributors may only have a mac development machine. Therefore the project should compile well enough for the typical development loop (e.g. build, running unit and e2e tests).

As issue #1556 puts it "I should be able to run the e2e tests from my laptop without having to jump through hoops."

What testing is done?
make test and ran e2e tests

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 25, 2024
Copy link

Code Coverage Diff

This PR does not change the code coverage

Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

The code looks good to me, but I do not have a Mac, and the PR description appears to indicate we haven't tested the e2e tests on MacOS.

Given that's the primary purpose of this PR can somebody with a Mac make sure to test at least the single-az and external tests on MacOS before this is approved?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2024
@AndrewSirenko
Copy link
Contributor Author

PR description appears to indicate we haven't tested the e2e tests on MacOS.

This was done, I have edited PR description from running to ran to be more clear!

@ConnorJC3
Copy link
Contributor

Ah, my bad, when you said "running" I thought you meant the CI tests. If they've all passed locally on a Mac, then

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7089339 into kubernetes-sigs:master Oct 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project does not build when GOOS=darwin
4 participants