Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetching test package version for kubetest in helm-tester #2203

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix fetching test package version for kubetest in helm-tester #2203

merged 1 commit into from
Oct 31, 2024
+17 −2

Conversation

torredil
Copy link
Member

Is this a bug fix or adding new feature?

Bug fix.

What is this PR about? / Why do we need it?

Fixes #2198

What testing is done?

helm test aws-ebs-csi-driver -n kube-system &
kubectl logs ebs-csi-driver-test -n kube-system -f

Test Suite Passed
kubetest2 test run completed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 31, 2024
@github-actions GitHub Actions
Copy link

Code Coverage Diff

This PR does not change the code coverage

AndrewSirenko
AndrewSirenko approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@AndrewSirenko AndrewSirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2024
@ConnorJC3
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2024
@k8s-ci-robot k8s-ci-robot merged commit eede784 into kubernetes-sigs:master Oct 31, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSirenko AndrewSirenko AndrewSirenko approved these changes

@ElijahQuinones ElijahQuinones Awaiting requested review from ElijahQuinones

Assignees

@AndrewSirenko AndrewSirenko

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ebs-csi-driver-test pod errors but runs indefinitely
4 participants
@torredil @ConnorJC3 @k8s-ci-robot @AndrewSirenko