Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Pull Request Template #2208

Merged

Conversation

AndrewSirenko
Copy link
Contributor

@AndrewSirenko AndrewSirenko commented Nov 5, 2024

What type of PR is this?

/kind cleanup

What is this PR about? / Why do we need it?

Add release-note to pull request template so that we can think about release-notes at PR time and use Kubernetes release-notes generator instead of hand-crafting release notes at the end of each release.

Also switches first question to suggesting to add a GitHub label. Hopefully one-day we can add an area/helm label as well.

Impact: Saves ~25 minutes crafting release notes (if you aren't using OSS-Repo-Management-Tools/get_pull_requests_since_last_version), and a team check-in about what note goes where.

How was this change tested?

N/A

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 5, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

Code Coverage Diff

This PR does not change the code coverage

@AndrewSirenko
Copy link
Contributor Author

Note creating release-notes becomes as easy as running:

GITHUB_TOKEN="PASTE_READ_ACCESS_TOKEN_HERE" release-notes \
  --discover=mergebase-to-latest \
  --org=kubernetes-sigs \
  --repo=aws-ebs-csi-driver \
  --required-author="" \
  --markdown-links \
  --output out.md \
  --dependencies=false

Can also show which dependencies changed by toggling --dependencies=true for those worried about CVEs.

Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2024
Copy link
Member

@ElijahQuinones ElijahQuinones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElijahQuinones

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2024
@ConnorJC3
Copy link
Contributor

/retest

Flake

@k8s-ci-robot k8s-ci-robot merged commit 2fae5d5 into kubernetes-sigs:master Nov 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants