Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finetune sidecar retry-interval-start #2221

Closed

Conversation

ElijahQuinones
Copy link
Member

What type of PR is this?

What is this PR about? / Why do we need it?

This PR changes the retry-interval-start of the provisioner, resizer, snapshotter and attacher sidecars

How was this change tested?

These changes where tested with scalability tests as well as testing an infeasible state within 30 minutes.

The scalability tests for the provisioner revealed that the overall time of the scalability tests was not negatively impacted by the increase in the retry-Interval-start,

The infeasible error tests revealed the following.

2 second retry-interval-start -> 1 gRPC  saved 
4 second retry-interval-start -> 2 gRPCs saved 
8 second retry-interval-start -> 3 gRPCs saved 

(The above infeasible is the case for the resizer and snapshotter as well )

As the scalability tests revealed that there is no negative time impact from increasing the retry-interval-start I have oped to select 4 seconds this both saves us 2 gRPCs and is not a staggering increases in the case that there is something that the tests run did not catch.

For the attacher side car the scalability tests revealed that the number of errors is not negatively impacted from moving from 1 second to 500 milliseconds.

The benefit of this is we can not manually induces another controllerPublishVolume gRPC and as such moving down to .5 seconds will allow us to have one more "instant" gRPC before we reach the 5 minute max.

Does this PR introduce a user-facing change?

Finetune provisioner, resizer, snapshotter, and attacher sidecars retry-interval-start value 

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 8, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Code Coverage Diff

This PR does not change the code coverage

Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than one small nitpick

charts/aws-ebs-csi-driver/templates/controller.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2024
@AndrewSirenko
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewSirenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2024
@ElijahQuinones
Copy link
Member Author

/retest

2 similar comments
@torredil
Copy link
Member

/retest

@ElijahQuinones
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

@ElijahQuinones: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-ebs-csi-driver-e2e-single-az 407b8ca link true /test pull-aws-ebs-csi-driver-e2e-single-az
pull-aws-ebs-csi-driver-test-e2e-external-eks-windows 407b8ca link true /test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants