-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finetune sidecar retry-interval-start #2221
Finetune sidecar retry-interval-start #2221
Conversation
Code Coverage DiffThis PR does not change the code coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm other than one small nitpick
42bc755
to
2cb4f77
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewSirenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
2 similar comments
/retest |
/retest |
2cb4f77
to
407b8ca
Compare
New changes are detected. LGTM label has been removed. |
@ElijahQuinones: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
What is this PR about? / Why do we need it?
This PR changes the retry-interval-start of the provisioner, resizer, snapshotter and attacher sidecars
How was this change tested?
These changes where tested with scalability tests as well as testing an infeasible state within 30 minutes.
The scalability tests for the provisioner revealed that the overall time of the scalability tests was not negatively impacted by the increase in the retry-Interval-start,
The infeasible error tests revealed the following.
(The above infeasible is the case for the resizer and snapshotter as well )
As the scalability tests revealed that there is no negative time impact from increasing the retry-interval-start I have oped to select
4 seconds
this both saves us 2 gRPCs and is not a staggering increases in the case that there is something that the tests run did not catch.For the attacher side car the scalability tests revealed that the number of errors is not negatively impacted from moving from 1 second to 500 milliseconds.
The benefit of this is we can not manually induces another controllerPublishVolume gRPC and as such moving down to .5 seconds will allow us to have one more "instant" gRPC before we reach the 5 minute max.
Does this PR introduce a user-facing change?