-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FIPS image and Helm option #2244
Conversation
Code Coverage DiffThis PR does not change the code coverage |
e85c10e
to
cc28cae
Compare
Signed-off-by: Connor Catlett <[email protected]>
# | ||
# The EBS CSI Driver FIPS images have not undergone FIPS certification, and no official guarnatee is made about the compliance of these images under the FIPS standard | ||
# Users relying on these images for FIPS compliance should perform their own independent evaluation | ||
fips: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we change it to enableFips
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about this, but it's not really "enabling" FIPS so the name would be misleading. Maybe fipsMode
or enableFipsMode
although those sound kinda janky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit/suggestion other than that LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually tested changes and found no issues.
/lgtm
/approve
/retest looks like flake /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewSirenko, torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
/kind feature
What is this PR about? / Why do we need it?
This PR adds a FIPS image and helm chart option
fips
that enables that image as well as deplying with the environment variable needed to instruct the AWS SDK to use FIPS endpoints.How was this change tested?
Manually/CI
Does this PR introduce a user-facing change?