CVE-2023-44487: disable HTTP2 for webhook server and bump controller-runtime to 0.14.7

[alebedev87]

Issue

N/A

Description

This PR addresses the HTTP2 Rapid Reset (CVE-2023-44487) by:

• disabling HTTP2 for the webhook server until the CVE is fully addressed in the standard library and Kubernetes.
• bumping controller-runtime to v0.14.7 which in turn bumped x/net and kube API.

Before the change:

$ oc get pods albc-aws-load-balancer-controller-666676c7bf-df7rp -o yaml | yq .spec.containers[0].args
- --cluster-name=alebedev-1026-csv9b
- --ingress-class=alb
- --aws-region=us-east-2
- --aws-vpc-id=vpc-09f727cc56ff10c9f

$ oc get svc aws-load-balancer-webhook-service
NAME                                TYPE           CLUSTER-IP       EXTERNAL-IP                                                               PORT(S)         AGE
aws-load-balancer-webhook-service   LoadBalancer   172.30.165.126   af2495b6963494f6e9b7b88a65e5eaf0-1803416629.us-east-2.elb.amazonaws.com   443:31795/TCP   40m

$ curl -kv https://af2495b6963494f6e9b7b88a65e5eaf0-1803416629.us-east-2.elb.amazonaws.com 2>&1 | grep 'ALPN'
* ALPN, offering h2
* ALPN, offering http/1.1
* ALPN, server accepted to use h2

After:

$ oc get pods albc-aws-load-balancer-controller-7bd4c4dff7-ksfx9 -o yaml | yq .spec.containers[0].args
- --cluster-name=alebedev-1026-csv9b
- --ingress-class=alb
- --aws-region=us-east-2
- --aws-vpc-id=vpc-09f727cc56ff10c9f
- --webhook-disable-http2

$ curl -kv https://af2495b6963494f6e9b7b88a65e5eaf0-1803416629.us-east-2.elb.amazonaws.com 2>&1 | grep 'ALPN'
* ALPN, offering h2
* ALPN, offering http/1.1
* ALPN, server accepted to use http/1.1

Note: A new flag for the HTTP2 disabling is added. I'm fine to remove the flag if it's not the common way.

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alebedev87
Once this PR has been reviewed and has the lgtm label, please assign m00nf1sh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @alebedev87. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[oliviassss]

@alebedev87, hi we have bumped up the x/net to v1.17.0 and update some other dependencies to address the CVEs we got regarding HTTP/2 in this PR: #3429.
Would the above fix work for you?
CVEs we got:
https://nvd.nist.gov/vuln/detail/CVE-2023-39325
https://nvd.nist.gov/vuln/detail/CVE-2023-3978

[alebedev87]

@oliviassss : From what I see in kubernetes/kubernetes#121197, bumping x/net is not enough. The case for the authorized users seems to be not addressed. I think that's why people disable HTTP2 in their code for the time being. WDYT?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.