Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDC configuration auto discovery support #3747

Closed
wants to merge 1 commit into from

Conversation

omerap12
Copy link
Member

@omerap12 omerap12 commented Jun 15, 2024

Issue

#2921

Description

Introduced new functionality to alb.ingress.kubernetes.io/auth-idp-oidc annotation, support for OIDC configuration using discoveryEndpoint to fetch OIDC details dynamically.
Enhanced documentation with instructions and example for using discoveryEndpoint in OIDC configuration.
Created unit tests to validate the implementation and functionality of OIDC Discovery feature.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omerap12
Once this PR has been reviewed and has the lgtm label, please assign johngmyers for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from kishorj and M00nF1sh June 15, 2024 16:24
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 43.75000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 18.23%. Comparing base (e5d625f) to head (9621e73).

Files Patch % Lines
pkg/networking/utils.go 0.00% 16 Missing ⚠️
pkg/ingress/auth_config_builder.go 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3747      +/-   ##
==========================================
+ Coverage   18.20%   18.23%   +0.02%     
==========================================
  Files         175      175              
  Lines       29280    29312      +32     
==========================================
+ Hits         5330     5344      +14     
- Misses      23584    23601      +17     
- Partials      366      367       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shraddhabang
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 25, 2024
@shraddhabang
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2024
@oliviassss
Copy link
Collaborator

@omerap12, thanks for the contribution, overall lgtm. can you please add the manual test in your PR description? Thanks/

@omerap12 omerap12 force-pushed the oidc_discovery_URL branch from cc3cd35 to fcc766f Compare August 9, 2024 14:51
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@omerap12 omerap12 force-pushed the oidc_discovery_URL branch from fcc766f to 487a69e Compare August 9, 2024 14:53
@omerap12
Copy link
Member Author

omerap12 commented Aug 9, 2024

@omerap12, thanks for the contribution, overall lgtm. can you please add the manual test in your PR description? Thanks/

Done :)

@omerap12 omerap12 force-pushed the oidc_discovery_URL branch from 487a69e to a16bfaa Compare August 9, 2024 18:52
@omerap12 omerap12 force-pushed the oidc_discovery_URL branch from a16bfaa to 0dfbdac Compare August 10, 2024 12:00
@omerap12 omerap12 requested a review from oliviassss August 10, 2024 13:03
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@omerap12
Copy link
Member Author

@oliviassss , should I close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants