-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OIDC configuration auto discovery support #3747
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omerap12 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3747 +/- ##
==========================================
+ Coverage 18.20% 18.23% +0.02%
==========================================
Files 175 175
Lines 29280 29312 +32
==========================================
+ Hits 5330 5344 +14
- Misses 23584 23601 +17
- Partials 366 367 +1 ☔ View full report in Codecov by Sentry. |
/ok-to-test |
/lgtm |
@omerap12, thanks for the contribution, overall lgtm. can you please add the manual test in your PR description? Thanks/ |
cc3cd35
to
fcc766f
Compare
New changes are detected. LGTM label has been removed. |
fcc766f
to
487a69e
Compare
Done :) |
487a69e
to
a16bfaa
Compare
Signed-off-by: Omer Aplatony <[email protected]>
a16bfaa
to
0dfbdac
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@oliviassss , should I close this? |
Issue
#2921
Description
Introduced new functionality to alb.ingress.kubernetes.io/auth-idp-oidc annotation, support for OIDC configuration using discoveryEndpoint to fetch OIDC details dynamically.
Enhanced documentation with instructions and example for using discoveryEndpoint in OIDC configuration.
Created unit tests to validate the implementation and functionality of OIDC Discovery feature.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯