Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip listener attributes reconcile for Isolated regions #3884

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Skip listener attributes reconcile for Isolated regions #3884

merged 1 commit into from
Oct 17, 2024

Conversation

wweiwei-li
Copy link
Collaborator

Description

  • Skip listener attributes reconcile for Isolated regions

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 8, 2024
@shraddhabang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shraddhabang, wweiwei-li, zac-nixon
Once this PR has been reviewed and has the lgtm label, please assign kishorj for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shraddhabang shraddhabang merged commit 1ea514f into kubernetes-sigs:main Oct 17, 2024
8 of 9 checks passed
shraddhabang pushed a commit to shraddhabang/aws-load-balancer-controller that referenced this pull request Oct 17, 2024
@wweiwei-li @shraddhabang
Skip listener attributes reconcile for Isolated regions (kubernetes-s…
6be4cec 
…igs#3884)
shraddhabang added a commit that referenced this pull request Oct 17, 2024
@shraddhabang @wweiwei-li
Release v2.9.2 (#3901)
22fcc22 
* Fix controller crash due enabling shield protection after AWS SDK Go v2 upgrades

* Skip listener attributes reconcile for Isolated regions (#3884)

* cut v2.9.2 release

---------

Co-authored-by: wweiwei-li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zac-nixon zac-nixon zac-nixon approved these changes

@kishorj kishorj Awaiting requested review from kishorj

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees

@shraddhabang shraddhabang

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wweiwei-li @shraddhabang @k8s-ci-robot @zac-nixon