Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alphabetic order in CRD for verify CRD to run #3911

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

shraddhabang
Copy link
Collaborator

Issue

Fix unit test action to verify CRD
https://github.com/kubernetes-sigs/aws-load-balancer-controller/actions/runs/11486517662/job/31968997753

Description

Fix alphabetical order of newly added annotation.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 23, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 23, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.45%. Comparing base (e5d625f) to head (aaa4932).
Report is 38 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3911       +/-   ##
===========================================
+ Coverage   18.20%   49.45%   +31.25%     
===========================================
  Files         175      200       +25     
  Lines       29280    11754    -17526     
===========================================
+ Hits         5330     5813      +483     
+ Misses      23584     5551    -18033     
- Partials      366      390       +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shraddhabang, zac-nixon
Once this PR has been reviewed and has the lgtm label, please assign johngmyers for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shraddhabang shraddhabang merged commit 06cb9ee into kubernetes-sigs:main Oct 24, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants