Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: order must match specified subnets #3925

Merged
merged 1 commit into from
Nov 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/networking/subnet_resolver.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ package networking
import (
"context"
"fmt"
ec2types "github.com/aws/aws-sdk-go-v2/service/ec2/types"
"sort"
"strings"

ec2types "github.com/aws/aws-sdk-go-v2/service/ec2/types"

awssdk "github.com/aws/aws-sdk-go-v2/aws"
ec2sdk "github.com/aws/aws-sdk-go-v2/service/ec2"
"github.com/go-logr/logr"
Expand Down Expand Up @@ -328,7 +329,6 @@ func (r *defaultSubnetsResolver) ResolveViaNameOrIDSlice(ctx context.Context, su
if err := r.validateSubnetsMinimalCount(resolvedSubnets, subnetLocale, resolveOpts); err != nil {
return nil, err
}
sortSubnetsByID(resolvedSubnets)
return resolvedSubnets, nil
}

Expand Down
Loading