Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gateway-api to v1.1.0 #277

Closed
wants to merge 2 commits into from

Conversation

cnvergence
Copy link

@cnvergence cnvergence commented Sep 3, 2024

As mentioned in #81, we should bump the gw-api version to the latest

Signed-off-by: Karol Szwaj <[email protected]>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cnvergence
Once this PR has been reviewed and has the lgtm label, please assign aryan9600 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 3, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @cnvergence!

It looks like this is your first PR to kubernetes-sigs/blixt 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/blixt has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 3, 2024
Signed-off-by: Karol Szwaj <[email protected]>
@shaneutt shaneutt added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 3, 2024
@shaneutt
Copy link
Member

shaneutt commented Sep 4, 2024

Hey @cnvergence! We appreciate you jumping on this. For some reason when we talked about this in #81 I had it in my head that we were talking about updating the Gateway API version in the Rust code, not the Golang control plane. We are in the midst of replacing the Golang code, so actually if this is not being as straightforward as it should be, maybe we could just drop it for now? I'm sorry for the crossed wires, this has actually got me thinking that maybe now is the time to just remove the old Golang control-plane to reduce confusion going forward 🤔

@shaneutt
Copy link
Member

shaneutt commented Sep 5, 2024

Spoke with @cnvergence in Slack (thanks for reaching out!) we're going to close this for now given the above context. Next steps to follow up are to finish the control-plane rewrite, and then we should be able to get back to updates and conformance tests for Gateway API 🚀

@shaneutt shaneutt closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants