Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement checksum #325

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: implement checksum #325

wants to merge 2 commits into from

Conversation

jokestax
Copy link
Contributor

Description

  • Use bpf_l3_csum_replace and bpf_l4_csum_replace instead of bpf_csum_diff.
  • Implement checksum updates for both IP and TCP headers after modifying source IP/port.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jokestax
Once this PR has been reviewed and has the lgtm label, please assign shaneutt for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 21, 2024
@jokestax jokestax mentioned this pull request Dec 21, 2024
Open
2 tasks
@shaneutt shaneutt linked an issue Jan 6, 2025 that may be closed by this pull request
Implement checksums properly in dataplane #25
Open
2 tasks
@shaneutt
Copy link
Member

shaneutt commented Jan 6, 2025

Heya 👋 I noticed this was draft, were you needing some more time for changes before reviews or did you want review while in draft?

@jokestax
Copy link
Contributor Author

jokestax commented Jan 6, 2025

Hello,I’d appreciate a review on this draft to ensure I’m heading in the right direction before proceeding with similar changes for ICMP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryan9600 aryan9600 Awaiting requested review from aryan9600

@astoycos astoycos Awaiting requested review from astoycos

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Blixt Project Board
Status: Review
Milestone
v0.4.0 - Rewrite of the control-plane...
Development

Successfully merging this pull request may close these issues.

Implement checksums properly in dataplane
3 participants
@jokestax @k8s-ci-robot @shaneutt