Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.27] fix: ignore Windows 2019 in ensureVMSSInPool for IPv6 backend pools only #6510

Merged

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Jul 3, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

doesn't try to add Windows 2019 VMSS to IPv6 backend pools because 2019 will never support IPv6 so it shouldn't be added.

Which issue(s) this PR fixes:

Fixes #6315

Special notes for your reviewer:

Does this PR introduce a user-facing change?

This only affects 1P, internal-to-Microsoft, customers. Windows 2019 with dual-stack is not possible otherwise.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 3, 2024
@nilo19 nilo19 changed the title [release-1.27] fix: ignore Windows 2019 in ensureVMSSInPool for IPv6 backend pools only [release-1.28] fix: ignore Windows 2019 in ensureVMSSInPool for IPv6 backend pools only Jul 3, 2024
@coveralls
Copy link

Coverage Status

coverage: 77.911% (-0.01%) from 77.922%
when pulling 8b439f2 on nilo19:fix/cherry-pick-6316-1-27
into 95a67a1 on kubernetes-sigs:release-1.27.

@nilo19 nilo19 changed the title [release-1.28] fix: ignore Windows 2019 in ensureVMSSInPool for IPv6 backend pools only [release-1.27] fix: ignore Windows 2019 in ensureVMSSInPool for IPv6 backend pools only Jul 3, 2024
@nilo19
Copy link
Contributor Author

nilo19 commented Jul 8, 2024

/retest

1 similar comment
@nilo19
Copy link
Contributor Author

nilo19 commented Jul 8, 2024

/retest

@feiskyer
Copy link
Member

feiskyer commented Jul 9, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1e7cb8c into kubernetes-sigs:release-1.27 Jul 9, 2024
13 checks passed
@nilo19 nilo19 deleted the fix/cherry-pick-6316-1-27 branch July 9, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants