-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.27] fix: ignore Windows 2019 in ensureVMSSInPool for IPv6 backend pools only #6510
Merged
k8s-ci-robot
merged 4 commits into
kubernetes-sigs:release-1.27
from
nilo19:fix/cherry-pick-6316-1-27
Jul 9, 2024
Merged
[release-1.27] fix: ignore Windows 2019 in ensureVMSSInPool for IPv6 backend pools only #6510
k8s-ci-robot
merged 4 commits into
kubernetes-sigs:release-1.27
from
nilo19:fix/cherry-pick-6316-1-27
Jul 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
kind/bug
Categorizes issue or PR as related to a bug.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
labels
Jul 3, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Jul 3, 2024
nilo19
changed the title
[release-1.27] fix: ignore Windows 2019 in ensureVMSSInPool for IPv6 backend pools only
[release-1.28] fix: ignore Windows 2019 in ensureVMSSInPool for IPv6 backend pools only
Jul 3, 2024
nilo19
changed the title
[release-1.28] fix: ignore Windows 2019 in ensureVMSSInPool for IPv6 backend pools only
[release-1.27] fix: ignore Windows 2019 in ensureVMSSInPool for IPv6 backend pools only
Jul 3, 2024
/retest |
1 similar comment
/retest |
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
doesn't try to add Windows 2019 VMSS to IPv6 backend pools because 2019 will never support IPv6 so it shouldn't be added.
Which issue(s) this PR fixes:
Fixes #6315
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: