Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore cluster not found on claim deletion #296

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Ignore cluster not found on claim deletion #296

merged 1 commit into from
Oct 15, 2024

Conversation

mcbenjemaa
Copy link
Member

@mcbenjemaa mcbenjemaa commented Oct 15, 2024 •
edited
Loading

This PR:

  • ignores the cluster paused check if the cluster is not found.

Fixes #289

@mcbenjemaa mcbenjemaa self-assigned this Oct 15, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 15, 2024
@k8s-ci-robot k8s-ci-robot requested review from schrej and srm09 October 15, 2024 10:53
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 15, 2024
@mcbenjemaa mcbenjemaa force-pushed the fix/cluster-paused-deletion branch from c2dcf68 to 990b1d0 Compare October 15, 2024 10:56
@mcbenjemaa mcbenjemaa force-pushed the fix/cluster-paused-deletion branch from 990b1d0 to aa79738 Compare October 15, 2024 10:59
schrej
schrej approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@schrej schrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: schrej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 806ce4d into main Oct 15, 2024
5 checks passed
@mcbenjemaa mcbenjemaa deleted the fix/cluster-paused-deletion branch October 15, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schrej schrej schrej approved these changes

@srm09 srm09 Awaiting requested review from srm09

Assignees

@schrej schrej

@mcbenjemaa mcbenjemaa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cluster paused detection blocks garbage collection of IPAddressClaims on cluster deletion
3 participants
@mcbenjemaa @k8s-ci-robot @schrej