✨feat(awsmachinepool): custom lifecyclehooks for machinepools · kubernetes-sigs/cluster-api-provider-aws@c036b28

Re-run triggered November 20, 2024 21:55

#4875

sebltm:lifecycle-hooks

Status Failure

Total duration 3m 23s

Artifacts –

pr-golangci-lint.yaml

on: pull_request

Matrix: lint

6 errors

lint: pkg/cloud/services/eks/nodegroup.go#L44

Comment should end in a period (godot)

lint: pkg/cloud/scope/machinepool.go#L399

exported: exported method MachinePoolScope.GetLifecycleHooks should have comment or be unexported (revive)

lint: pkg/cloud/scope/managednodegroup.go#L415

exported: exported method ManagedMachinePoolScope.GetLifecycleHooks should have comment or be unexported (revive)

lint: pkg/cloud/services/autoscaling/lifecyclehook.go#L35

exported: comment on exported method Service.DescribeLifecycleHooks should be of the form "DescribeLifecycleHooks ..." (revive)

lint: pkg/cloud/scope/managednodegroup.go#L181

ST1016: methods on the same type should have the same receiver name (seen 1x "m", 38x "s") (stylecheck)

issues found