🐛 Filter out AWS internal tags when reconciling #5181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/L
fiunchinho
commented
Oct 24, 2024
| @@ -34,14 +34,7 @@ import ( | |||
| ) | |||
|
|
|||
| var ( | |||
| bp = infrav1.BuildParams{ | |||
There was a problem hiding this comment.
I inlined the BuildParams object on each test case to make it easier to see what's being tested.
fiunchinho
changed the title
|
/test pull-cluster-api-provider-aws-test |
|
/test pull-cluster-api-provider-aws-e2e |
fiunchinho
force-pushed
the
filter-out-aws-internal-tags
branch
from
3ef7e0f
to
95d253a
Compare
|
/test pull-cluster-api-provider-aws-e2e |
s3rj1k
reviewed
Oct 29, 2024
fiunchinho
force-pushed
the
filter-out-aws-internal-tags
branch
from
95d253a
to
4c61f2b
Compare
|
/test pull-cluster-api-provider-aws-e2e |
1 similar comment
|
/test pull-cluster-api-provider-aws-e2e |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndiDog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Tags that start with
aws:are considered internal AWS tags and can't be add or removed.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #5120
Special notes for your reviewer:
Checklist:
Release note: