✨ WIP: Initial dedicated hosts implementation

[faermanj]

/kind feature

What this PR does / why we need it:

Let users allocate machines to dedicated hosts.

Special notes for your reviewer:

Dedicated hosts must be pre-allocated.
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/dedicated-hosts-overview.html

Checklist:

• squashed commits
• includes documentation
• includes emoji in title
• adds unit tests
• adds or updates e2e tests

Release note:

NONE

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mtulio]

Hey @faermanj - thanks for pinging. I have some questions about the API and test steps.

[mtulio]

What about this approach if you are using only to logging?

Suggested change

	placementStr := input.Placement.GoString()
	s.scope.Warn("Placement already set for instance, overwriting with dedicated host placement",
	"hostId", i.HostID,
	"affinity", i.HostAffinity,
	"placement", placementStr)
	s.scope.Warn("Placement already set for instance, overwriting with dedicated host placement",
	"hostId", i.HostID,
	"affinity", i.HostAffinity,
	"placement", input.Placement.GoString())

[mtulio]

Suggested change

	// Affinity specifies the dedicated host affinity setting for the instance.
	// When affinity is set to Host, an instance started onto a specific host always restarts on the same host if stopped.
	// +optional
	// +kubebuilder:validation:Enum:=Default;Host
	HostAffinity *string `json:"hostAffinity,omitempty"`
	// HostAffinity specifies the dedicated host affinity setting for the instance.
	// When hostAffinity is set to Host, an instance started onto a specific host always restarts on the same host if stopped.
	// +optional
	// +kubebuilder:validation:Enum:=Default;Host
	HostAffinity *string `json:"hostAffinity,omitempty"`

[mtulio]

what about clusterVars, or maybe add the map directly to the ClusterctlVariables as it is used only there ?

[mtulio]

Do you need to set the defaults here too? IMHO it also would be nice to mention HostAffinity depends on HostID.

[mtulio]

considering the feature is adding a field to the machineSpec, is it recommended to create a new cluster every time or you can use an existing generic cluster to create a new machine to validate if it has been provisioned to a Dedicated Host? (this is a general question, not sure if this is a recommended approach)
cc @richardcase @nrb

[richardcase]

In the EKS tests we reuse an existing cluster to help speed thing sup. In the non-EKS side (i.e. unmanaged suite) historically, new clusters were created every time. However, if we can speed up the e2e by just reusing an existing cluster, that would be great.

[rvanderp3]

superseded by #5548

[k8s-ci-robot]

@faermanj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-aws-test	72ecf00	link	true	/test pull-cluster-api-provider-aws-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.