-
Notifications
You must be signed in to change notification settings - Fork 610
✨ Add all ManagedMachineAMITypes supported by AWS API #5540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
✨ Add all ManagedMachineAMITypes supported by AWS API #5540
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @afarbos! |
Hi @afarbos. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
63aae2e
to
054ff36
Compare
/ok-to-test |
054ff36
to
b3b83d9
Compare
/test pull-cluster-api-provider-aws-e2e-eks |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Heavily inspired from #5472
Adding support for ALL EKS Managed Node Group AMIs currently supported in order.
List originates from CreateNodeGroup API docs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2009 by adding support for BottleRocket
Special notes for your reviewer:
Checklist:
Release note: