Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Pin Azure disk CSI driver Helm chart to v1.29.0" #4279

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Revert "Pin Azure disk CSI driver Helm chart to v1.29.0" #4279

merged 1 commit into from
Nov 21, 2023

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Nov 16, 2023 •
edited
Loading

This reverts commit 5b00ff8.

What type of PR is this?

/kind cleanup

What this PR does / why we need it: fix: v1.29.1.1-windows-hp image by andyzhangx · Pull Request #2060 · kubernetes-sigs/azuredisk-csi-driver (github.com) fixed the issue

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4251

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 16, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 16, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d192f41) 59.22% compared to head (dda5b7e) 59.22%.
Report is 26 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4279   +/-   ##
=======================================
  Coverage   59.22%   59.22%           
=======================================
  Files         185      185           
  Lines       18777    18777           
=======================================
  Hits        11121    11121           
  Misses       7047     7047           
  Partials      609      609

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@troy0820
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7d3423680aef0f4d132fc331e605074a632b7f52

@sonasingh46
Copy link
Contributor

/retest

@dtzar dtzar modified the milestones: v1.12, v1.13 Nov 16, 2023
@CecileRobertMichon
Copy link
Contributor Author

/hold

to make sure #4155 merges first

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2023
@troy0820
Copy link
Member

#4155 merged @CecileRobertMichon hold cancel?

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2023
@CecileRobertMichon
Copy link
Contributor Author

yes thanks!

/assign @willie-yao @jackfrancis

@nojnhuh nojnhuh linked an issue Nov 20, 2023 that may be closed by this pull request
Revert Azure Disk CSI driver Helm chart pin #4251
Closed
@CecileRobertMichon
Copy link
Contributor Author

/assign @nojnhuh

nojnhuh
nojnhuh reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8017657 into kubernetes-sigs:main Nov 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojnhuh nojnhuh nojnhuh left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@willie-yao willie-yao Awaiting requested review from willie-yao

Assignees

@jackfrancis jackfrancis

@troy0820 troy0820

@nojnhuh nojnhuh

@willie-yao willie-yao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

Revert Azure Disk CSI driver Helm chart pin
8 participants
@CecileRobertMichon @troy0820 @k8s-ci-robot @sonasingh46 @nojnhuh @jackfrancis @dtzar @willie-yao