Remove deprecated kubelet credential provider flag

[CecileRobertMichon]

What type of PR is this?

/kind cleanup

What this PR does / why we need it: In-tree credential kubelet providers are deprecated and will be removed soon. See kubernetes/kubernetes#122595.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Remove deprecated kubelet credential provider flag

[CecileRobertMichon]

@lzhecheng PTAL

When will there be a helm chart available to install the OOT credential provider for non-CI use cases? Currently we are still installing it with a custom script in cloud init.

[dims]

/approve
/lgtm

thanks a ton @CecileRobertMichon !

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 86d5298d1fb354a8d869f4a2e142e46280f43f1a

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf1ae32) 61.96% compared to head (1836525) 61.96%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4436   +/-   ##
=======================================
  Coverage   61.96%   61.96%           
=======================================
  Files         188      188           
  Lines       18768    18768           
=======================================
  Hits        11630    11630           
  Misses       6500     6500           
  Partials      638      638           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[CecileRobertMichon]

/cherry-pick release-1.12

[k8s-infra-cherrypick-robot]

@CecileRobertMichon: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[CecileRobertMichon]

/assign @mboersma

[mboersma]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 8d1e82cb81b0c0406920ef4be65602db2c0d07f3

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nojnhuh]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 9981cf5fd2254b11e14279137e67ed98b34e5f8d

[k8s-ci-robot]

@CecileRobertMichon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-windows-custom-builds	1836525	link	false	/test pull-cluster-api-provider-azure-windows-custom-builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-infra-cherrypick-robot]

@CecileRobertMichon: new pull request created: #4437

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lzhecheng]

@lzhecheng PTAL

When will there be a helm chart available to install the OOT credential provider for non-CI use cases? Currently we are still installing it with a custom script in cloud init.

I created an issue in cloud-provider-azure: kubernetes-sigs/cloud-provider-azure#5231
Now, it is not of high priority, but it is in the roadmap. I think this will be done when switching to OOT credential provider in AKS.

[lzhecheng]

@CecileRobertMichon I think this PR should remove other occurrences of --azure-container-registry-config. Do you have any reason to keep them?
e.g. The cluster-template-prow-ci-version.yaml one. This PR deletes the one for Linux worker but not the ones for control-plane node and windows worker.
https://github.com/CecileRobertMichon/cluster-api-provider-azure/blob/18365252ec8270e0fed095fe96b230e01b066a91/templates/test/ci/cluster-template-prow-ci-version.yaml#L187C11-L187C70

[CecileRobertMichon]

@lzhecheng thanks for catching! #4455 should fix it