Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot(deps): bump tj-actions/changed-files from 43.0.1 to 44.0.0 #4694

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 1, 2024

Bumps tj-actions/changed-files from 43.0.1 to 44.0.0.

Release notes

Sourced from tj-actions/changed-files's releases.

v44.0.0

🔥🔥 BREAKING CHANGE 🔥🔥

Overview

We've made a significant update to how pull requests (PRs) from forked repositories are processed. This improvement not only streamlines the handling of such PRs but also fixes a previously identified issue.

Before the Change

Previously, when you created a pull request from a forked repository, any files changed in the target branch after the PR creation would erroneously appear as part of the PR's changed files. This made it difficult to distinguish between the actual changes introduced by the PR and subsequent changes made directly to the target branch.

What Has Changed

With this update, a pull request from a fork will now only include the files that were explicitly changed in the fork. This ensures that the list of changed files in a PR accurately reflects the contributions from the fork, without being muddled by unrelated changes to the target branch.


What's Changed

New Contributors

Full Changelog: tj-actions/changed-files@v43.0.1...v44.0.0

Changelog

Sourced from tj-actions/changed-files's changelog.

Changelog

44.0.0 - (2024-03-27)

🐛 Bug Fixes

  • Ensure the fork remote doesn't exists before creating it (#2012) (4bbd49b) - (Tonye Jack)
  • Update previos sha for forks (#2011) (f0e7702) - (Tonye Jack)
  • Update to add the fork remote (#2010) (6354e6c) - (Tonye Jack)
  • Check for setting remote urls for forks (#2009) (1176164) - (Tonye Jack)
  • Bug with prs from forks returning incorrect set of changed files (#2007) (4ff7936) - (Tonye Jack)

➖ Remove

🔄 Update

  • Updated README.md (#2016)

Co-authored-by: jackton1 [email protected] (2d756ea) - (tj-actions[bot])

  • Update README.md (2d21bbb) - (Tonye Jack)
  • Updated README.md (#2013)

Co-authored-by: jackton1 [email protected] (2ca8dc4) - (tj-actions[bot])

  • Update README.md (4621617) - (tonyejack1)
  • Update README.md (c6557ed) - (Tonye Jack)
  • Update README.md (0713a11) - (Tonye Jack)

⚙️ Miscellaneous Tasks

  • Update description of outputs removing asterisks (#2015) (ce497c3) - (tonyejack1)
  • Update description of other_deleted_files output (#2008) (ee096d6) - (tonyejack1)
  • deps: Update typescript-eslint monorepo to v7.4.0 (0647424) - (renovate[bot])
  • deps: Lock file maintenance (efe5e6c) - (renovate[bot])

⬆️ Upgrades

  • Upgraded to v43.0.1 (#2004)

Co-authored-by: jackton1 [email protected] (01e9662) - (tj-actions[bot])

43.0.1 - (2024-03-20)

🐛 Bug Fixes

  • Remove warning with detecting the local git repository when using Github's REST API (#2002) (077b23f) - (Tonye Jack)

📦 Bumps

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 1, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 1, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.73%. Comparing base (2c69370) to head (6aaec40).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4694   +/-   ##
=======================================
  Coverage   62.73%   62.73%           
=======================================
  Files         192      192           
  Lines       15641    15641           
=======================================
  Hits         9812     9812           
  Misses       5146     5146           
  Partials      683      683           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mboersma
Copy link
Contributor

mboersma commented Apr 1, 2024

@dependabot rebase

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 43.0.1 to 44.0.0.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@20576b4...2d756ea)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/tj-actions/changed-files-44.0.0 branch from 44d73e3 to 6aaec40 Compare April 1, 2024 14:39
@mboersma
Copy link
Contributor

mboersma commented Apr 1, 2024

Dependency review seems not to understand that this PR is fixing the vulnerability it identified. :-(

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8c07177f4513a3b77528b62bd6f21adde42e86e6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2024
@mboersma
Copy link
Contributor

mboersma commented Apr 1, 2024

/cherrypick release-1.13
/cherrypick release-1.14

@k8s-infra-cherrypick-robot

@mboersma: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.13
/cherrypick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma
Copy link
Contributor

mboersma commented Apr 1, 2024

/override dependency-review

@k8s-ci-robot
Copy link
Contributor

@mboersma: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • dependency-review

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • deploy/netlify
  • pull-cluster-api-provider-azure-apidiff
  • pull-cluster-api-provider-azure-build
  • pull-cluster-api-provider-azure-test
  • pull-cluster-api-provider-azure-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override dependency-review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma mboersma removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 1, 2024
@mboersma
Copy link
Contributor

mboersma commented Apr 1, 2024

/close

There's some chicken-and-egg problem here, similar to #4577. Let's wait until there's a version bump that doesn't trigger this vulnerability check.

@k8s-ci-robot
Copy link
Contributor

@mboersma: Closed this PR.

In response to this:

/close

There's some chicken-and-egg problem here, similar to #4577. Let's wait until there's a version bump that doesn't trigger this vulnerability check.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 1, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/github_actions/tj-actions/changed-files-44.0.0 branch April 1, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants