-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove upstream-windows-serial-slow configs #5049
ci: remove upstream-windows-serial-slow configs #5049
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5049 +/- ##
=======================================
Coverage 51.15% 51.15%
=======================================
Files 274 274
Lines 24665 24665
=======================================
Hits 12617 12617
Misses 11262 11262
Partials 786 786 ☔ View full report in Codecov by Sentry. |
did you want to clean up files like https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/test/e2e/data/kubetest/upstream-windows-serial-slow.yaml? |
af58129
to
8f5b740
Compare
lol I thought I had! done now |
Signed-off-by: Jack Francis <[email protected]>
8f5b740
to
8bcbd9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 25d160661465aaa309c0ac62181e40a60c07edf8
|
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR removes "Serial" + "Slow" Windows conformance configs, now that we no longer have a native test to gather that coverage. Ref:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: