remove unnecassary caching of of golangci-lint #5166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
needs-rebase
golangci-lint step auto caches the binary. Explicit caching step is not needed anymore. Refer to https://github.com/golangci/golangci-lint-action?tab=readme-ov-file#internals Of course, we could cache a specific version of golangci-lint instead of go.mod hash. But effort to create that logic outweighs its impact. However, golangci-lint.cache-{runner_os}-{working_directory}-{interval_number}-{go.mod_hash} has its advantages; it updates itself with go.mod changes. We delete older caches using auto delete cache workflow.
nawazkh
force-pushed
the
update_golang_ci_3
branch
from
6e0b48a to
b591374
Compare
k8s-ci-robot
removed
the
needs-rebase
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5166 +/- ##
=======================================
Coverage 51.35% 51.35%
=======================================
Files 273 273
Lines 24671 24671
=======================================
Hits 12670 12670
Misses 11212 11212
Partials 789 789 ☔ View full report in Codecov by Sentry. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 1ccff33e5d306e78cbe4975d58a9901cf016d982
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
golangci-lint step auto caches the binary. Explicit caching step is not needed anymore. Refer to https://github.com/golangci/golangci-lint-action?tab=readme-ov-file#internals
Of course, we could cache a specific version of golangci-lint instead of go.mod hash. But effort to create that logic
outweighs its impact. However, golangci-lint.cache-{runner_os}-{working_directory}-{interval_number}-{go.mod_hash} has its advantages; it updates itself with go.mod changes.
We delete older caches using auto delete cache workflow. [WIP] Remove GitHub-actions caches every Tuesday midnight. #5165
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: