-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.17] re-enable AKS BYO node test #5230
[release-1.17] re-enable AKS BYO node test #5230
Conversation
/cherry-pick release-1.16 |
@nojnhuh: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.17 #5230 +/- ##
=============================================
Coverage 52.88% 52.88%
=============================================
Files 273 273
Lines 29172 29172
=============================================
Hits 15429 15429
Misses 12944 12944
Partials 799 799 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest
Clever! I wondered how we would backport this.
LGTM label has been added. Git tree hash: 41f9329e225a415a252ace2f6650ed2e49e0b09a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@nojnhuh: new pull request created: #5233 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
This PR updates the AKS BYO node test to use images from the new Community Gallery (#5167) which are back on track with versions of Kubernetes in use by AKS. This allows us to re-enable the test.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: