MachinePool always update vmssState

[mweibel]

What type of PR is this?
/kind bug

What this PR does / why we need it:
Updates ScaleSets service to always update the scope's vmss state with the latest data.
Previously, a long running operation would cause the vmssState to not be updated and delayed creation of AzureMachinePoolMachines until much later when that long running operation completed.
This change avoids this and updates the vmssState to what is retrieved from the API at all times.
The call does not make more API requests because the VMSS GET request was done anyway but its result ignored.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes kubernetes-sigs/cluster-api#9858 for CAPZ

Special notes for your reviewer:

Question: Should I add a test which tests this specific case with a long running operation? Is there any existing test which resembles this?

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Improves state update handling when running long operations on VMSS

[k8s-ci-robot]

Hi @mweibel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[willie-yao]

/ok-to-test

[willie-yao]

/lgtm
/assign @nojnhuh

[jackfrancis]

/lgtm cancel

I think we want to classify this as a bug fix so we can backport, in which case we'll want to remove the updates to internal interfaces.

[codecov]

Codecov Report

Attention: Patch coverage is 45.83333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 52.51%. Comparing base (5b2cbce) to head (4f65eac).
Report is 43 commits behind head on main.

Files with missing lines	Patch %	Lines
azure/services/scalesets/scalesets.go	45.83%	8 Missing and 5 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5292      +/-   ##
==========================================
- Coverage   52.57%   52.51%   -0.06%     
==========================================
  Files         272      272              
  Lines       29408    29430      +22     
==========================================
- Hits        15460    15456       -4     
- Misses      13150    13172      +22     
- Partials      798      802       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mweibel]

@willie-yao @jackfrancis thanks - I removed the interface change from the PR.

[willie-yao]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 5ac3751f7646a6118760dc3c45edf8d0571a3e33

[willie-yao]

/test pull-cluster-api-provider-azure-apiversion-upgrade

[mweibel]

@jackfrancis ping :)

[mboersma]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mboersma]

/cherry-pick release-1.17

[k8s-infra-cherrypick-robot]

@mboersma: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mboersma]

/cherry-pick release-1.16

[k8s-infra-cherrypick-robot]

@mboersma: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@mboersma: new pull request created: #5327

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@mboersma: new pull request created: #5328

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.