-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tiltfile to use env variable to check aks cluster is being used #5306
Conversation
Welcome @rihib! |
Hi @rihib. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cc. @nawazkh |
/ok-to-test |
/cc @nawazkh |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5306 +/- ##
==========================================
- Coverage 52.53% 52.43% -0.11%
==========================================
Files 272 272
Lines 29372 29401 +29
==========================================
- Hits 15432 15417 -15
- Misses 13143 13178 +35
- Partials 797 806 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @nawazkh
LGTM label has been added. Git tree hash: ef9a33ae196af101f940d8b6e7b16cde377b98ed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry for the delay, this looks good to me pending one suggestion.
@nawazkh Thank you for the review! I have made corrections based on your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 73313802c950dc3056a56232deb0dae7619d0d58
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I apologize for lgtm-ing this PR. This fix does not work, we need to revert this change. This change does not work because each Make target runs in its own sub-shell, setting MGMT_CLUSTER_TYPE in one target does not automatically make it available in another target. |
This is really my mistake, I am sorry @rihib . The author was following my directions put up in the issue #5289 . The right fix would be to update the exported env variables in tilt-settings.yaml or have an another env file where @rihib , if you are still up for it, could you please experiment with saving I will continue my thought in the issue. |
@nawazkh Got it, thanks for the clarification! I’ll give it a try. |
What type of PR is this?
kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5289
Special notes for your reviewer:
TODOs:
Release note: