Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tiltfile to use env variable to check aks cluster is being used #5306

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

rihib
Copy link
Contributor

@rihib rihib commented Nov 24, 2024

What type of PR is this?
kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5289

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:


@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 24, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @rihib!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 24, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @rihib. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rihib
Copy link
Contributor Author

rihib commented Nov 24, 2024

cc. @nawazkh

@mboersma
Copy link
Contributor

/ok-to-test
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 10, 2024
@mboersma
Copy link
Contributor

/cc @nawazkh

@k8s-ci-robot k8s-ci-robot requested a review from nawazkh December 10, 2024 18:27
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.43%. Comparing base (78e1385) to head (4cbde49).
Report is 55 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5306      +/-   ##
==========================================
- Coverage   52.53%   52.43%   -0.11%     
==========================================
  Files         272      272              
  Lines       29372    29401      +29     
==========================================
- Hits        15432    15417      -15     
- Misses      13143    13178      +35     
- Partials      797      806       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @nawazkh

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ef9a33ae196af101f940d8b6e7b16cde377b98ed

Copy link
Member

@nawazkh nawazkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry for the delay, this looks good to me pending one suggestion.

Tiltfile Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2024
@rihib
Copy link
Contributor Author

rihib commented Dec 28, 2024

@nawazkh Thank you for the review! I have made corrections based on your feedback.

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 30, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 73313802c950dc3056a56232deb0dae7619d0d58

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 31, 2024
@k8s-ci-robot k8s-ci-robot merged commit 177964e into kubernetes-sigs:main Dec 31, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 31, 2024
@nawazkh nawazkh mentioned this pull request Jan 3, 2025
4 tasks
@nawazkh
Copy link
Member

nawazkh commented Jan 3, 2025

I apologize for lgtm-ing this PR. This fix does not work, we need to revert this change.

This change does not work because each Make target runs in its own sub-shell, setting MGMT_CLUSTER_TYPE in one target does not automatically make it available in another target.

@nawazkh
Copy link
Member

nawazkh commented Jan 3, 2025

This is really my mistake, I am sorry @rihib . The author was following my directions put up in the issue #5289 .

The right fix would be to update the exported env variables in tilt-settings.yaml or have an another env file where MGMT_CLUSTER_TYPE can be saved and sourced right before running Tiltfile.

@rihib , if you are still up for it, could you please experiment with saving MGMT_CLUSTER_TYPE env file and source it in the tilt-uprecipe ? I think the original idea of exporting and unsetting inaks-createandkind-createare still valid, we have to set theMGMT_CLUSTER_TYPE` in the env file instead.

I will continue my thought in the issue.

@rihib
Copy link
Contributor Author

rihib commented Jan 5, 2025

@nawazkh Got it, thanks for the clarification! I’ll give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update Tiltfile to differentiate between aks and kind cluster
4 participants