Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage for managed cluster webhooks #1339

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Increase test coverage for managed cluster webhooks #1339

merged 3 commits into from
Oct 21, 2024

Conversation

salasberryfin
Copy link
Contributor

@salasberryfin salasberryfin commented Oct 20, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

As we already started discussions on promoting managed clusters out of experimental (refer to this issue), this PR improves test coverage of control plane, cluster and machine pool webhooks. Some existing machine pool test cases have been formatted to align with the newly added scenarios (which are similar to the ones used by other providers).

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Improve managed clusters test coverage

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 20, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 20, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 20, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit 3752077
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/67160b6e6a6bc000081abacc
😎 Deploy Preview https://deploy-preview-1339--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cpanato
cpanato requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments

exp/api/v1beta1/gcpmanagedcluster_webhook_test.go Outdated Show resolved Hide resolved
exp/api/v1beta1/gcpmanagedcontrolplane_webhook_test.go Outdated Show resolved Hide resolved
exp/api/v1beta1/gcpmanagedcontrolplane_webhook_test.go
)

var (
vV1_27_1 = "v1.27.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be hardcoded? can we avoid that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is simply used as a valid version placeholder but the value itself is not relevant. I'd say we won't need to update this in the foreseeable future, so it won't hurt that it is hard-coded. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the clarification

@salasberryfin salasberryfin force-pushed the gcpmanaged-improve-test-coverage branch from af55bae to 3752077 Compare October 21, 2024 08:06
cpanato
cpanato approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, salasberryfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit fe60c6a into kubernetes-sigs:main Oct 21, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@dims dims Awaiting requested review from dims

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@salasberryfin @k8s-ci-robot @cpanato