-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 Set previous release tag version for RELEASE CANDIDATE/BETA RELEASE #10435
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: chandankumar4 <[email protected]>
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @chandankumar4. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: chandankumar4 <[email protected]>
@@ -1166,7 +1164,7 @@ release-notes-tool: | |||
|
|||
.PHONY: release-notes | |||
release-notes: release-notes-tool | |||
./bin/notes --release $(RELEASE_TAG) > CHANGELOG/$(RELEASE_TAG).md | |||
./bin/notes --release $(RELEASE_TAG) --previous-release-version "$(PREVIOUS_VERSION_TAG)" > CHANGELOG/$(RELEASE_TAG).md | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related: is it documented anywhere that PREVIOUS_VERSION_TAG has to be set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it's not documented anywhere yet, is there any place where I can document it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cahillsf I assume you have an idea :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cluster-api/docs/release/release-tasks.md
Line 361 in a52ab37
#### Create PR for release notes |
Ideally we properly document it with an example for a rc and a stable version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep looks like the right place to me too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the release docs
Signed-off-by: chandankumar4 <[email protected]>
```bash | ||
# RELEASE_TAG should be the new desired tag (note: at this point the tag does not yet exist). | ||
# PREVIOUS_VERSION_TAG is the previous released tag for determining the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would this work for the first pre-release version without a pre-release precedent? Is that worth documenting as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the docs for the same, a minor code change was also required for it.
Signed-off-by: chandankumar4 <[email protected]>
@@ -187,12 +187,6 @@ func validateConfig(config *notesCmdConfig, releaseType string) error { | |||
} | |||
} | |||
|
|||
if releaseType != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this going away?
PRE_RELEASE=true | ||
endif | ||
# the previous release tag, e.g., v0.3.9, excluding pre-release tags | ||
PREVIOUS_TAG ?= $(shell git tag -l | grep -E "^v[0-9]+\.[0-9]+\.[0-9]+$$" | sort -V | grep -B1 $(RELEASE_TAG) | head -n 1 2>/dev/null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where was this used? I can't find any ref
@chandankumar4 do you have time to address the findings? |
Sure, Sorry I totally missed this PR, I'll update the PR. Thanks |
What this PR does / why we need it:
For RELEASE CANDIDATE/BETA RELEASE
For Release TAG
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #10396