-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 [wip] bump controller-gen and regenerate manifests to optimize RBAC #10612
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to drop the +required from v1alpha3 + v1alpha4 conditions to get rid of the change in the CRDs. Type are internal now anyway
@@ -1000,6 +1000,7 @@ spec: | |||
can be useful (see .node.status.conditions), the ability to deconflict is important. | |||
type: string | |||
required: | |||
- lastTransitionTime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's talk about this with Fabrizio. I think this happens because CT now supports the upstream +required marker. That was somehow used on v1alpha3 & v1alpha4 (with v1beta1 we dropped omitempty on this field so it became required per default)
Just have to decide what we want to do. Shouldn't matter much as these types are now only used for conversion and not served anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is only making explicit in the OpenAPI spec the fact that this field is required (it is not a pointer, it doesn't have omitempty), then I'm ok with this change
@chrischdi I would appreciate if we can merge this PR before the other CAPI PR. Because I already verified that all the changes in this PR are correct (apart from the last nit regarding lastTransitionTime + rebase on top of CT main) |
f26c268
to
73d968d
Compare
Rebased to latest master commit for controller-tools. |
/test help |
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-e2e-main |
One enter too much which closed it... /test pull-cluster-api-e2e-main |
@chrischdi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/area dependency /hold This should wait for v0.16 of controller-tools (~ August) |
@chrischdi can you please rebase onto latest CAPI & CT main and regenerate? |
73d968d
to
763a0d2
Compare
done :-) |
Interesting, no additional diff (I was wondering if kubernetes-sigs/controller-tools#877 leads to some changes) EDIT: moment, ah looks like it worked (had a problem with pull) |
@@ -67,7 +66,6 @@ spec: | |||
type: string | |||
description: |- | |||
ExtraArgs is an extra set of flags to pass to the control plane component. | |||
TODO: This is temporary and ideally we would like to switch all components to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabriziopandini We should audit our APIs for multi-line TODOs and make them single line, see: kubernetes-sigs/controller-tools#877 (PR description)
Atm we still end up with half the TODO in the CRD, which is not great :)
uses controller-gen from kubernetes-sigs/controller-tools#937
What this PR does / why we need it:
Bumps controller-gen to commit kubernetes-sigs/controller-tools@ed2fbe2 .
This includes:
Which deduplicates rbac stuff and makes the roles better readable.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Area example:
/area dependency