-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update implicit skipping remediation for Cluster/MD pause #10827
🌱 Update implicit skipping remediation for Cluster/MD pause #10827
Conversation
Hi @kashifest. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
docs/book/src/tasks/automated-machine-management/healthchecking.md
Outdated
Show resolved
Hide resolved
The current documentation is a bit ambiguous since Cluster cannot be paused using paused annotation. This PR updates the docs and specifies that Cluster expect `Spec.Paused = true` for it to be paused. Signed-off-by: Kashif Khan <[email protected]>
2d43b09
to
e348a9b
Compare
@kashifest This seems to be the same as / overlap with #10817 |
@sbueringer thanks for pointing out. I will close it in favor of #10817 |
@kashifest: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The current documentation is a bit ambiguous since Cluster cannot be paused using paused annotation. This PR updates the docs and specifies that Cluster and MD expect
Spec.Paused = true
for it to be paused.Signed-off-by: Kashif Khan [email protected]
/area documentation