Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add conformance testing to clusterctl framework #3306

Closed

Conversation

randomvariable
Copy link
Member

@randomvariable randomvariable commented Jul 8, 2020

What this PR does / why we need it:

  • Helpers for running kubetest (for e2e or conformance) against a cluster provisioned using the clusterctl
    test framework
  • Adds mechanism to set a Kubernetes version based on the latest CI artifacts
  • Can run kubetest from the latest CI artifacts using Docker against a workload proxy

Based on port with additional cleanup of kubernetes-sigs/cluster-api-provider-aws#1760:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2141
Fixes #3569

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 8, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 8, 2020
@fabriziopandini
Copy link
Member

/assign

@CecileRobertMichon
Copy link
Contributor

/assign

/cc @chewong

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@randomvariable thanks for this PR!
First of all, a background question: This code runs the kubernetes e2e test in a container using docker,
pointing to a cluster identified by a cluster proxy, is that right?

Given that this is a really valuable utility, I have left some comments in order to check if we can achieve a better decoupling from the clusterctl config, thus allowing usage of this utility in a stand-alone way.

test/framework/kubetest/setup.go Outdated Show resolved Hide resolved
test/framework/kubetest/setup.go Outdated Show resolved Hide resolved
@randomvariable
Copy link
Member Author

This code runs the kubernetes e2e test in a container using docker, pointing to a cluster identified by a cluster proxy, is that right?

Yup, that's right. Thanks for the comments, the way it is now is sort of based on the history of moving the old CAPA scripts from bash to go, so should be able to address in a cleaner way.

@randomvariable
Copy link
Member Author

Will be returning to this soon, but @sedefsavas discovered that in CAPA, the conformance test fails to run on OS X due to docker volume mount issues when running the kubetest image.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cecilerobertmichon
You can assign the PR to them by writing /assign @cecilerobertmichon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@randomvariable
Copy link
Member Author

/close

Temporarily closing whilst I constantly push WIP bits to test on the Mac on the other screen.

@k8s-ci-robot
Copy link
Contributor

@randomvariable: Closed this PR.

In response to this:

/close

Temporarily closing whilst I constantly push WIP bits to test on the Mac on the other screen.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@randomvariable
Copy link
Member Author

Got this working on MacOS

/reopen

@k8s-ci-robot
Copy link
Contributor

@randomvariable: Failed to re-open PR: state cannot be changed. The conformance branch was force-pushed or recreated.

In response to this:

Got this working on MacOS

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for CAPI e2e for main branch of Kubernetes [e2e framework] Enable conformance test suite run
4 participants