-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add conformance testing to clusterctl framework #3306
Conversation
/assign |
/assign /cc @chewong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@randomvariable thanks for this PR!
First of all, a background question: This code runs the kubernetes e2e test in a container using docker,
pointing to a cluster identified by a cluster proxy, is that right?
Given that this is a really valuable utility, I have left some comments in order to check if we can achieve a better decoupling from the clusterctl config, thus allowing usage of this utility in a stand-alone way.
Yup, that's right. Thanks for the comments, the way it is now is sort of based on the history of moving the old CAPA scripts from bash to go, so should be able to address in a cleaner way. |
Will be returning to this soon, but @sedefsavas discovered that in CAPA, the conformance test fails to run on OS X due to docker volume mount issues when running the kubetest image. |
3fa4647
to
5275d15
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5275d15
to
1076877
Compare
/close Temporarily closing whilst I constantly push WIP bits to test on the Mac on the other screen. |
@randomvariable: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Got this working on MacOS /reopen |
@randomvariable: Failed to re-open PR: state cannot be changed. The conformance branch was force-pushed or recreated. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
test framework
Based on port with additional cleanup of kubernetes-sigs/cluster-api-provider-aws#1760:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2141
Fixes #3569