-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Use Kubernetes 1.24 in quickstart and CAPD, bump to kind v0.14 #6513
🐛 Use Kubernetes 1.24 in quickstart and CAPD, bump to kind v0.14 #6513
Conversation
36bb445
to
6a5c02c
Compare
/test help |
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-apidiff-main |
/test pull-cluster-api-e2e-workload-upgrade-1-23-latest-main |
pull-cluster-api-e2e-workload-upgrade-1-23-latest-main currently fails because it tries to pull the kind image {
"ts": 1652511846453.4377,
"caller": "controller/controller.go:317",
"msg": "controller/dockermachine: Reconciler error",
"reconciler group": "infrastructure.cluster.x-k8s.io",
"reconciler kind": "DockerMachine",
"name": "k8s-upgrade-and-conformance-x4acz0-control-plane-sls88-wf7s7",
"namespace": "k8s-upgrade-and-conformance-suiysm",
"err": "failed to create worker DockerMachine: failure pulling container image: invalid reference format",
"errVerbose": "failure pulling container image: invalid reference format
sigs.k8s.io/cluster-api/test/infrastructure/docker/internal/docker.(*Machine).Create
sigs.k8s.io/cluster-api/test/infrastructure/docker/internal/docker/machine.go:224
sigs.k8s.io/cluster-api/test/infrastructure/docker/internal/controllers.(*DockerMachineReconciler).reconcileNormal
sigs.k8s.io/cluster-api/test/infrastructure/docker/internal/controllers/dockermachine_controller.go:236
sigs.k8s.io/cluster-api/test/infrastructure/docker/internal/controllers.(*DockerMachineReconciler).Reconcile
sigs.k8s.io/cluster-api/test/infrastructure/docker/internal/controllers/dockermachine_controller.go:159
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:114
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:311
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:227
runtime.goexit
runtime/asm_amd64.s:1581
failed to create worker DockerMachine
sigs.k8s.io/cluster-api/test/infrastructure/docker/internal/controllers.(*DockerMachineReconciler).reconcileNormal
sigs.k8s.io/cluster-api/test/infrastructure/docker/internal/controllers/dockermachine_controller.go:237
sigs.k8s.io/cluster-api/test/infrastructure/docker/internal/controllers.(*DockerMachineReconciler).Reconcile
sigs.k8s.io/cluster-api/test/infrastructure/docker/internal/controllers/dockermachine_controller.go:159
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:114
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:311
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:227
runtime.goexit
runtime/asm_amd64.s:1581"
} I'm curious if this worked before :-) |
460804a
to
c976856
Compare
|
b27dab5
to
ad92ec9
Compare
/test pull-cluster-api-apidiff-main |
ad92ec9
to
8f34f36
Compare
/test pull-cluster-api-apidiff-main |
8f34f36
to
48999f1
Compare
/test pull-cluster-api-apidiff-main Changed last commit to replace |
/test pull-cluster-api-e2e-full-main |
/test pull-cluster-api-e2e-workload-upgrade-1-23-latest-main |
828b14b
to
8d5e398
Compare
After tests got green 🎉 : did some cleanup and squashed the commits /test pull-cluster-api-apidiff-main |
Seems to be a false-positive:
|
Final tasks
/test pull-cluster-api-e2e-workload-upgrade-1-23-latest-main |
/test pull-cluster-api-e2e-workload-upgrade-1-23-latest-main |
1 similar comment
/test pull-cluster-api-e2e-workload-upgrade-1-23-latest-main |
19e30dd
to
eb011ad
Compare
/test pull-cluster-api-e2e-workload-upgrade-1-23-latest-main @fabriziopandini Ready for review / merge in my opinion. /cherry-pick release-1.1 |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* Use Kubernetes 1.24 in quickstart and CAPD * Bumps kind to v0.14 for v1.24 support as kind management cluster * Migrates CI upgrade tests to use cluster class and version aware patches for cgroupDriver * Implement workaround for DockerMachinePools which are not supported by ClusterClass to use correct cgroupDriver on upgrade tests. Co-authored-by: killianmuldoon <[email protected]> Co-authored-by: sbueringer <[email protected]>
eb011ad
to
bbfb5de
Compare
/test pull-cluster-api-e2e-workload-upgrade-1-23-latest-main |
@chrischdi @sbueringer thanks for stepping up in fixing CAPD and our CI to adapt to recent changes in kind, really appreciated! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer: #6513 failed to apply on top of branch "release-1.1":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thx! the majority of the work was done by @chrischdi and @killianmuldoon, thx folks!! I'll check testgrid etc. ... . |
What this PR does / why we need it:
cgroupDriver: systemd
by removal of pinning tocgroupDriver: cgroupfs
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #6509
Fixes #4621
Still WIP: