🐛 Fakeclient: Don't return items on invalid selector

[alvaroaleman]

Currently, if a List call to the fake client references an invalid fieldSelector, we will return an error and put all items into the passed List. Avoid putting anything into the passed list if the selector is invalid.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alvaroaleman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[troy0820]

Would a returned list from a field selector produce an error? I am under the assumption that a list call returns no error and an empty list, making the call successful but resulting in the items being empty. len(list.Items) == 0

[sbueringer]

Are we missing something by not zero'ing obj anymore?

[alvaroaleman]

Not sure why I did it this way, changed it to just keep zeroing obj instead, ptal

[alvaroaleman]

Would a returned list from a field selector produce an error? I am under the assumption that a list call returns no error and an empty list, making the call successful but resulting in the items being empty. len(list.Items) == 0

I am not sure I follow the question, are you asking if an error is returned if the selector is invalid? If so, then yeah it is:

controller-runtime/pkg/client/fake/client_test.go

Line 1324 in fafee8c

Expect(err).To(HaveOccurred())