Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing: fix context cancellation during shutdown #1618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LukeCarrier
Copy link
Contributor

@LukeCarrier LukeCarrier commented Jan 30, 2025

tracing.Shutdown() must be invoked before done(), else the context will be cancelled before it's invoked and the following error will be emitted:

E0130 14:31:04.963323       1 tracing.go:156] "failed to shutdown the trace exporter" err="context canceled"

Interestingly, not observed when running with a deschedulingInterval, but reliably reproducible when running as a CronJob.

Nope, I do see it, I just also see metrics that have already been flushed.

tracing.Shutdown() must be invoked before done(), else the context will
be cancelled before it's invoked and the following error will be
emitted:

    E0130 14:31:04.963323       1 tracing.go:156] "failed to shutdown the trace exporter" err="context canceled"

Interestingly, not observed when running with a deschedulingInterval,
but reliably reproducible when running as a CronJob.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign knelasevero for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @LukeCarrier. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants