Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove too slow test #5014

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

mloiseleur
Copy link
Contributor

What does it do ?

It removes a specific test on OCI provider init.
This specific test can only work reliably in the OCI cloud infrastructure.

Motivation

External-dns is not here to test OCI SDK, especially when it requires internal OCI endpoint.

With this test:

ok  	sigs.k8s.io/external-dns/provider/oci	361.274s

Without this test:

go test -timeout 600s -run "^TestNewOCIProvider\$"
ok  	sigs.k8s.io/external-dns/provider/oci	0.007s

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 17, 2025
@k8s-ci-robot k8s-ci-robot requested a review from szuecs January 17, 2025 20:33
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 17, 2025
@szuecs
Copy link
Contributor

szuecs commented Jan 19, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2025
@mloiseleur
Copy link
Contributor Author

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

@mloiseleur: you cannot LGTM your own PR.

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@szuecs
Copy link
Contributor

szuecs commented Jan 20, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit d947881 into kubernetes-sigs:master Jan 20, 2025
13 checks passed
@mloiseleur mloiseleur deleted the rm/slow-test branch January 21, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants