-
Notifications
You must be signed in to change notification settings - Fork 538
Update golangci v2 #3802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update golangci v2 #3802
Conversation
Signed-off-by: Tyler Auerbeck <[email protected]>
Signed-off-by: Tyler Auerbeck <[email protected]>
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tylerauerbeck The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @tylerauerbeck! |
Hi @tylerauerbeck. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Tyler Auerbeck <[email protected]>
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR updates golangci-lint to v2 to keep the linters and linting tool up to date.
NOTE: I broke the fix for a specific lint
static check QF1008
into a second commit as different projects tend to have different opinions on this. If it's desired to leave those in place and instead ignore this lint, we can go back and drop that commit instead and either configure this in the config file or use//nolint
where appropriate.Which issue(s) this PR fixes:
Fixes #3801
Does this PR introduce a user-facing change?:
NONE