switch to use snapshots.insert instead of disks.createsnapshot #1857
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
| switch volKey.Type() { | ||
| case meta.Zonal: | ||
| if description == "" { | ||
| description = "Snapshot created by GCE-PD CSI Driver" | ||
| } | ||
| return cloud.createZonalDiskSnapshot(ctx, project, volKey, snapshotName, snapshotParams, description) | ||
| case meta.Regional: | ||
| if description == "" { | ||
| description = "Regional Snapshot created by GCE-PD CSI Driver" |
There was a problem hiding this comment.
It doesn't look like you're setting description on the request. Also I'd invert the description empty string check, and the volKey Type check.
There was a problem hiding this comment.
what do you mean by
Also I'd invert the description empty string check, and the volKey Type check.
Thanks for the description catch.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leiyiz, pwschuurman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
|
/retest |
|
/test pull-gcp-compute-persistent-disk-csi-driver-verify |
|
/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration |
|
@leiyiz: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
If we use disks.CreateSnapshot, there could be a race condition where snapshot.Status is "READY" but the snapshot creation is not actually done. Snapshots.Insert API avoids this problem.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: