-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for negative provisioned-throughput-on-create parameter #1896
base: master
Are you sure you want to change the base?
Conversation
…r for hyperdisk-throughput
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cemakd The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @cemakd! |
Hi @cemakd. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/hold cancel |
/retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
If the StorageClass is of type hyperdisk-throughput and the parameter
provisioned-throughput-on-create
has a negative value, we don't include the negative value when calling the GCE API to provision the volume. Instead a sensible default is used injected by GCE API, leading to a confusing UX.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: