Skip to content

Commit

Permalink
Remove webhooks from CRDs and unbreak K8s 1.22
Browse files Browse the repository at this point in the history
HNC hasn't has CRD conversion webhooks implemented since v0.6, but
somehow we still had them in our CRDs. It looks like earlier versions of
K8s simply ignored them but 1.22 hits internal errors if the webhooks
can't be called, even though no conversion is actually occurring.

Tested: can't install HNC successfully on 1.22 without this change; can
install successfully with it. Also, before this change, if I edit the
CRDs on the server to remove the conversion webhooks, HNC starts
working.
  • Loading branch information
adrianludwin committed Oct 18, 2021
1 parent 7a25601 commit 66687ac
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions config/crd/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ patchesStrategicMerge:
# [WEBHOOK] To enable webhook, uncomment all the sections with [WEBHOOK] prefix.
# patches here are for enabling the conversion webhook for each CRD
# and setting served and storage versions.
- patches/webhook_in_hierarchyconfigurations.yaml
- patches/webhook_in_hncconfigurations.yaml
- patches/webhook_in_subnamespaceanchors.yaml
# - patches/webhook_in_hierarchyconfigurations.yaml
# - patches/webhook_in_hncconfigurations.yaml
# - patches/webhook_in_subnamespaceanchors.yaml
# +kubebuilder:scaffold:crdkustomizewebhookpatch

# [CERTMANAGER] To enable webhook, uncomment all the sections with [CERTMANAGER] prefix.
Expand Down

0 comments on commit 66687ac

Please sign in to comment.