Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream test status instead of logs #225

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stream test status instead of logs #225

wants to merge 1 commit into from

Conversation

rjsadow
Copy link
Collaborator

@rjsadow rjsadow commented Dec 18, 2024

Added a new function that will find the number of specs and the number of tests ran in the e2e.log to better indicate the progress of the tests being run.

I think there' still some work to do on this PR but it will help with #223

Example output with this PR

$ bin/hydrophone --conformance
08:03:21 INF API endpoint: https://127.0.0.1:34383
08:03:21 INF Server version: version.Info{Major:"1", Minor:"28", GitVersion:"v1.28.13", GitCommit:"024ab2a13ff700705efd3ab63a0e27c38c462070", GitTreeState:"clean", BuildDate:"2024-08-14T19:44:20Z", GoVersion:"go1.22.5", Compiler:"gc", Platform:"linux/amd64"}
08:03:21 INF Using namespace: conformance
08:03:21 INF Using conformance image: registry.k8s.io/conformance:v1.28.13
08:03:21 INF Using busybox image: registry.k8s.io/e2e-test-images/busybox:1.36.1-1
08:03:21 INF Test framework will start 1 thread(s) and use verbosity level 4.
08:03:21 INF Created Namespace conformance.
08:03:21 INF Created ServiceAccount conformance-serviceaccount.
08:03:21 INF Created Clusterrole conformance-serviceaccount:conformance.
08:03:21 INF Created ClusterRoleBinding conformance-serviceaccount-role:conformance.
08:03:21 INF Created Pod e2e-conformance-test.
08:03:21 INF Waiting up to 5m0s for Pod to start...
⠈⠁ Running test 97 of 380

/wip
/hold

cc @BenTheElder

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rjsadow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2024
@BenTheElder
Copy link
Member

Very cool, thank you!

I will need a bit before I get a chance to review (~out until EOY but might get a moment to follow up), but also don't wait for mine if someone else can 😅

@k8s-ci-robot
Copy link
Contributor

@rjsadow: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-hydrophone-verify 4b141c9 link true /test pull-hydrophone-verify
pull-hydrophone-simple-run 4b141c9 link true /test pull-hydrophone-simple-run
pull-hydrophone-namespaced-run 4b141c9 link true /test pull-hydrophone-namespaced-run
pull-hydrophone-dry-run 4b141c9 link true /test pull-hydrophone-dry-run

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants