-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxmox-ubuntu-22.04: Make boot command wait times more robust #1484
proxmox-ubuntu-22.04: Make boot command wait times more robust #1484
Conversation
This increases the wait times after pressing Enter key from 5 second to 10 seconds during the boot command insertion, which more results in more robust VM startup process. Previous value of 5 seconds can result in failure due to insufficient wait time: ==> proxmox-iso.ubuntu-2204: Typing the boot command ==> proxmox-iso.ubuntu-2204: Error running boot command: Put "https://10.9.1.0:8006/api2/json/nodes/pm0/qemu/104/sendkey": EOF
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @tbabej! |
Hi @tbabej. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @tbabej could you sign the CLA please? We can process this change then - seems sensible to me though! |
@tbabej could you sign the Kubernetes CLA through the link in the comment above? This looks like a simple change we can merge once that is done. Thanks! |
/close Please re-open this if it’s still an issue and you’ve signed the Kubernetes CLA. |
@mboersma: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This increases the wait times after pressing Enter key from 5 second to 10 seconds during the boot command insertion, which more results in more robust VM startup process. Previous value of 5 seconds can result in failure due to insufficient wait time: