-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WS2025 VHD #1527
base: main
Are you sure you want to change the base?
Add WS2025 VHD #1527
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @TinaMor! |
Hi @TinaMor. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@TinaMor could you take a look at the CLA? Thanks! |
/ok-to-test |
export AZURE_LOCATION="${AZURE_LOCATION:-southcentralus}" | ||
|
||
# Creating Azure VMs from a Marketplace Image requires a Purchase Plan | ||
# https://portal.azure.com/#view/Microsoft_Azure_Marketplace/GalleryItemDetailsBladeNopdl/id/microsoftwindowsserver.microsoftserveroperatingsystems-previews/selectionMode~/false/resourceGroupId//resourceGroupLocation//dontDiscardJourney~/false | ||
export PLAN_PUBLISHER="${PLAN_PUBLISHER:-''}" | ||
export PLAN_OFFER="${PLAN_OFFER:-''}" | ||
export PLAN_NAME="${PLAN_NAME:-''}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the need for this change. We create other sigs (ws2019 and ws2022) without these values. Where you getting errors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you try to create an AzVM with the generated image without the plan information we get:
{
"code": "VMMarketplaceInvalidInput",
"message": "Unable to deploy from the Marketplace image or a custom image sourced from Marketplace image. The part number in the purchase information for VM '/subscriptions/xxxx/resourceGroups/cluster-api-images/providers/Microsoft.Compute/virtualMachines/xxxx' is not as expected. Beware that the Plan object's properties are case-sensitive. "
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error should go away when we switch to the 2025 GA images so at that point we can drop PLAN information added to workaround this issue for the preview images
looks like the VHD failed with:
|
71d6aea
to
d42a18a
Compare
08cb993
to
3414500
Compare
/test pull-azure-sigs |
/retest |
354b8c9
to
6b90c93
Compare
/retest |
6b90c93
to
611eefd
Compare
/retest |
611eefd
to
eb7cd7c
Compare
/retest |
- Adds commands for Windows Server 2025 SIG images - Adds Purchase Plan info for Azure Market Place Images # - Adds Purchase Plan info for Azure Market Place Images
eb7cd7c
to
e490b93
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just want to see if this is reliable in CI with the longer timeout.
/test pull-azure-sigs
/lgtm |
/test pull-azure-sigs Previous run failed here: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_image-builder/1527/pull-azure-sigs/1836788700290224128 |
@TinaMor: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@mboersma Not sure why the WS25 job is timing out despite the tests passing. Any thoughts? |
It's hard to tell what's going on. All I can see in the logs is that the WS25 job succeeded and got as far as but timed out there instead of going on to delete the resource group:
We could try running it locally to see if it gets stuck there too, maybe it would give us some way to debug things. |
PR Description
Server Image: Windows Server 2025 Preview
Adds Windows Server 2025 as a VHD and SIG target. This will allow us to add Windows Server 2025 to the Azure marketplace.
make build-azure-sig-windows-2025-containerd
make build-azure-vhd-windows-2025-containerd
- NOT IMPLEMENTEDWhy is build VHD not implemented?
Creating VMs from unmanaged disks will no longer be possible in the near future.
When we build VHDs with the command,
make build-azure-vhd-windows-2025-containerd
, we get a build error:Packer is displaying the following warning:
According to Microsoft documentation:
There is no workaround for creating a VHD with the WS2025 preview image, and creating an unmanaged disk with this preview image on the Azure Portal isn't possible either. Given the deprecation warnings, consider phasing out the use of unmanaged disks altogether and start preparing for this transition.
Why WS2025 purchase plan information added?
When creating a VM with the generated image, plan information is required.
Example:
Known issues with Windows Server 2025 Preview Image
Failing test: Key Vault gMSA CCG interface is registered
gMSA test fails because the CCG Interface value is missing. We skip this test for Windows Server 2025 images only
Failing test: Test Windows Features Installed
The test fails on the first run but passes on rerun. We add a retry argument when calling the
goss validate
command