-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate away from google.com gcp project k8s-testimages #107
Conversation
Signed-off-by: cpanato <[email protected]>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why test-infra and not a subproject-specific GCP project?
good question to @ameukam |
|
test-infra doesn't seem right for testing ingress-controllers, though - we do already have k8s-staging-ingress-controller-conformance. From as directional POV, what do we want as a project?
As such, it seems like building it in the same project that has the staging GCR is the right thing to do... |
What do we do with this? Approve or try to adjust? |
These images had been used for Gateway API, but we actually just completed a migration away from them today (kubernetes-sigs/gateway-api#2468). For the past several years, the only updates this repo was getting was just to update conformance images for Gateway API, so we decided to pull those into the main GW API repo and by extension I think this specific project is effectively archived at this point, and I don't know of anyone regularly running these tests. I'm not sure it's worth the effort to make changes here. Instead, I do know that the conformance images used by Gateway API will likely continue to get significant usage and updates, so if there are any similar improvements we could make there, definitely let us know. |
@robscott we can close this PR and request to archive this repo is done by sig-network ? |
I'm not 100% sure what to do here. We know that the Ingress API is essentially frozen and not going to change, which would suggest that these conformance tests would also not change. On the other hand, the Ingress API is not going away and archiving this repo may give the wrong message on that front. Interested in what others think here as well. /cc @shaneutt @youngnick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@thockin we will need to override the failing checks to get this merged. also what is the best slack channel to talk with you about next steps for this repo? |
sig-network is the right channel, but if you need specific people you probably need to name them :) |
/retest I don't know much about these checks - @robscott ? |
@cpanato: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Yeah, it makes sense to me to keep this around rather than going full archive. |
this is something we can skip to get this PR merged? |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Related to kubernetes/k8s.io#1523
/assign @ameukam @thockin @bowei
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Does this PR introduce a user-facing change?: