-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit test for jobset webhook updates #464
add unit test for jobset webhook updates #464
Conversation
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
f69c44a
to
f77c1e9
Compare
Thanks for improving the test coverage here. Let's merge this after the complex validation PR is checked in, I think merge conflicts will be easier to resolve that way than the reverse |
Sounds good. I was thinking about #463 and I was going to add unit tests for that code. Decided to move it to a separate PR so we can at least document better that elastic jobs are not supported yet. |
/hold Waiting on kubectl-validate code. |
f77c1e9
to
16f2f45
Compare
I think we can merge this now. |
/hold cancel |
16f2f45
to
1e26dc4
Compare
@danielvegamyhre I think we can get this in now. PTAL |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre, kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add unit test for updates.