Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2e test to show that resuming JobSet after restoring PodTemplate does not work [EXPERIMENT] #635

Closed
wants to merge 1 commit into from
Closed

E2e test to show that resuming JobSet after restoring PodTemplate does not work [EXPERIMENT] #635

wants to merge 1 commit into from

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Aug 2, 2024 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This PR is just to demonstrate the issue: #624

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mimowo
Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 2, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 2, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
🔨 Latest commit 184e361
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/66b1d8fd5e6c590008c165ee

@mimowo mimowo force-pushed the fix-suspending-jobset-experiment branch from 91ec75c to d506855 Compare August 2, 2024 21:17
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2024
@mimowo mimowo force-pushed the fix-suspending-jobset-experiment branch from 94150ca to 9a05508 Compare August 5, 2024 17:55
@mimowo mimowo force-pushed the fix-suspending-jobset-experiment branch from b0db360 to 184e361 Compare August 6, 2024 08:04
@k8s-ci-robot
Copy link
Contributor

@mimowo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-jobset-test-e2e-main-1-30 184e361 link true /test pull-jobset-test-e2e-main-1-30
pull-jobset-test-e2e-main-1-29 184e361 link true /test pull-jobset-test-e2e-main-1-29
pull-jobset-test-e2e-main-1-28 184e361 link true /test pull-jobset-test-e2e-main-1-28
pull-jobset-test-e2e-main-1-27 184e361 link true /test pull-jobset-test-e2e-main-1-27

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mimowo mimowo changed the title Fix restoring PodTemplate on JobSet suspend [EXPERIMENT] E2e test to show that resuming JobSet after restoring PodTemplate does not work [EXPERIMENT] Aug 6, 2024
This was referenced Aug 6, 2024
Closed
Closed
kannon92
kannon92 reviewed Aug 6, 2024
View reviewed changes
test/e2e/e2e_test.go
@@ -246,3 +328,25 @@ func sleepTestJobSet(ns *corev1.Namespace) *testing.JobSetWrapper {
Replicas(int32(replicas)).
Obj())
}

func shortSleepTestJobSet(ns *corev1.Namespace) *testing.JobSetWrapper {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would reuse the sleep job above for this. Maybe we can add an arg so we don’t have two functions that set sleep somewhat differently.

Not sure what your plan for this Pr is so you can ignore if there is no point to merge.

Copy link
Contributor Author

@mimowo mimowo Aug 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is just to show the issue: #624. However, I would like eventually to get merged one of the fix PRs #625 or #640, and both have a similar helper function.

So, if you add a similar function in your work, then we can align and reuse it.

@danielvegamyhre
Copy link
Contributor

Can this be closed now

@mimowo
Copy link
Contributor Author

mimowo commented Aug 6, 2024

Can this be closed now

Sure
/close

@k8s-ci-robot
Copy link
Contributor

@mimowo: Closed this PR.

In response to this:

Can this be closed now

Sure
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mimowo @k8s-ci-robot @danielvegamyhre @kannon92