Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Propose Drift Hash Versioning #1015

Merged
merged 1 commit into from
Mar 6, 2024
Merged

RFC: Propose Drift Hash Versioning #1015

merged 1 commit into from
Mar 6, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description
The purpose of this RFC is to Propose option around ways to preform CRD changes to Karpenter and have all nodes in a cluster considered drifted. Related issue: #957

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 15, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 15, 2024
@engedaam engedaam force-pushed the drift-versioning-design branch 2 times, most recently from a2dd08f to f00e849 Compare February 15, 2024 18:31
@engedaam engedaam mentioned this pull request Feb 15, 2024
Merged
@engedaam engedaam force-pushed the drift-versioning-design branch 3 times, most recently from f0a2097 to 45e8770 Compare February 15, 2024 23:12
@coveralls
Copy link

coveralls commented Feb 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8179305061

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 81.097%
Totals Coverage Status
Change from base Build 8175773696: 0.09%
Covered Lines: 8173
Relevant Lines: 10078
💛 - Coveralls

tallaxes
tallaxes reviewed Feb 21, 2024
View reviewed changes
Copy link

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits / suggested cleanup from the first reading

designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the drift-versioning-design branch 5 times, most recently from a452c4c to b876833 Compare February 22, 2024 01:27
Bryce-Soghigian
Bryce-Soghigian reviewed Feb 22, 2024
View reviewed changes
Copy link
Member

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall some solid approaches, others already left good review on sensitive areas. Thanks for including me by asking for my review :)

WIll take another pass when all comments on other areas are addressed 🫡

designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
jonathan-innis
jonathan-innis reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Bunch of nits, structural comments, and high-level feedback.

designs/drift-hash-versioning.md Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
jonathan-innis
jonathan-innis reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just some nits on wording! This is a really nice, well-written RFC!

designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
designs/drift-hash-versioning.md Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the drift-versioning-design branch 2 times, most recently from 40bfecb to d953ab1 Compare March 6, 2024 05:33
jonathan-innis
jonathan-innis reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 6, 2024
jonathan-innis
jonathan-innis reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Wait for a second review from @njtran

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2024
@engedaam engedaam force-pushed the drift-versioning-design branch 3 times, most recently from c0b56f0 to baf38c2 Compare March 6, 2024 17:14
@njtran
Copy link
Contributor

njtran commented Mar 6, 2024

/release-hold
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engedaam, jonathan-innis, njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jonathan-innis,njtran]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@njtran
Copy link
Contributor

njtran commented Mar 6, 2024

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8a4f670 into kubernetes-sigs:main Mar 6, 2024
12 checks passed
@engedaam engedaam deleted the drift-versioning-design branch March 6, 2024 22:18
@jonathan-innis jonathan-innis mentioned this pull request Mar 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtran njtran njtran left review comments

@tallaxes tallaxes tallaxes left review comments

@jonathan-innis jonathan-innis jonathan-innis left review comments

@Bryce-Soghigian Bryce-Soghigian Bryce-Soghigian left review comments

@garvinp-stripe garvinp-stripe garvinp-stripe left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@njtran njtran

@jonathan-innis jonathan-innis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@engedaam @coveralls @njtran @k8s-ci-robot @tallaxes @jonathan-innis @Bryce-Soghigian @garvinp-stripe