Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented UnschedulablePodsCount metric #1698

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implemented UnschedulablePodsCount metric #1698

wants to merge 3 commits into from

Conversation

edibble21
Copy link

Fixes #705

Description
Implemented UnschedulablePodsCount metric for Scheduler

How was this change tested?
implemented tests
make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: edibble21
Once this PR has been reviewed and has the lgtm label, please assign jonathan-innis for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 19, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @edibble21. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 19, 2024
@coveralls
Copy link

coveralls commented Sep 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10947482559

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 4 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 80.684%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/consolidation.go 4 87.25%
pkg/controllers/provisioning/scheduling/preferences.go 7 86.67%
Totals Coverage Status
Change from base Build 10931444492: -0.08%
Covered Lines: 8417
Relevant Lines: 10432
💛 - Coveralls

rschalo
rschalo reviewed Sep 20, 2024
View reviewed changes
pkg/controllers/provisioning/scheduling/suite_test.go
Comment on lines +3715 to +3716
g.Expect(lo.FromPtr(m.Gauge.Value)).To(BeNumerically(">=", 0))
}, 10*time.Second).Should(Succeed())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this just test for the existence of the metric or do we expect that it should be greater than 0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtran njtran njtran left review comments

@rschalo rschalo rschalo left review comments

@engedaam engedaam Awaiting requested review from engedaam

@tallaxes tallaxes Awaiting requested review from tallaxes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unschedulable Pod Metric
5 participants
@edibble21 @k8s-ci-robot @coveralls @njtran @rschalo