Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove jackfrancis from karpenter-reviewers #2064

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonathan-innis
Copy link
Member

Fixes #N/A

Description

Removing @jackfrancis from reviewers since he's become less directly involved in maintaining the project

Brandon shows as < 10 contributions in the last year: https://k8s.devstats.cncf.io/d/13/developer-activity-counts-by-repository-group?orgId=1&var-period_name=Last%20year&var-metric=contributions&var-repogroup_name=All&var-repo_name=kubernetes-sigs%2Fkarpenter&var-country_name=All

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13772345229

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 81.61%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/consolidation.go 4 85.55%
Totals Coverage Status
Change from base Build 13728019186: 0.0%
Covered Lines: 9599
Relevant Lines: 11762

💛 - Coveralls

@jackfrancis
Copy link
Contributor

Thanks @jonathan-innis and karpenter team for continuing to move this forward at impressive speed! Looking forward to more intersections via SIG Autoscaling in the near future and would love to contribute here in the future if cycles allow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants