Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag 0.1.0 release #226

Merged
merged 2 commits into from
Jan 16, 2019
Merged

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Jan 16, 2019

it's time :-)
fixes #208

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 16, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2019
@BenTheElder
Copy link
Member Author

really it is past time

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder BenTheElder mentioned this pull request Jan 16, 2019
@BenTheElder
Copy link
Member Author

this process is sorta goofy, I have to manually push the actual release tag afterwards with my write access anyhow since github doesn't seem to have any other mechanism for that. going to self-merge 🤷‍♂️

@BenTheElder BenTheElder added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 904944a into kubernetes-sigs:master Jan 16, 2019
@BenTheElder BenTheElder deleted the release-time branch January 16, 2019 04:39
@tao12345666333
Copy link
Member

@BenTheElder can we add some ci jobs using GitHub API to do this? https://developer.github.com/v3/repos/releases/#create-a-release

we can add one VERSION file and make the ci job watch it for release.

@BenTheElder
Copy link
Member Author

@tao12345666333 creating a release like that requires referencing a tag (tag_name) so I think it won't buy us much. We also still have to push a tag, write the release notes, and post the binaries. I looked at automating more of that but the uploading and tagging part is quick & simple, and automated release notes will not be as good as human curated notes I think :-)

We script (hack/release/create.sh):

  • updating the version file
  • creating the tag
  • building binaries for all platforms
  • updating the version file again

Manually:

  • PR the version file
  • Push the tag
  • Create a release entry / write release notes, upload the binaries to that

@BenTheElder
Copy link
Member Author

we are looking at #197 though for automation of the images, and if we do this more often it will take less time to write the notes hopefully :-)

@tao12345666333
Copy link
Member

Thanks for your explanation. 👍

@neolit123
Copy link
Member

neolit123 commented Jan 16, 2019

The current kind Config is now at kind.sigs.k8s.io/v1alpha2, with support for multi-node clusters! (thanks @fabriziopandini!)

we should have outlined that multi-node is enabled on the config side, but not in the backend - i.e. WIP?

@BenTheElder
Copy link
Member Author

@neolit123 multi-node should work (?), but not EG HA, external etcd etc.

@neolit123
Copy link
Member

hmm, @fabriziopandini could you please comment.
was under the impression that there is still something in the works there.
maybe i should just test myself...

@BenTheElder
Copy link
Member Author

BenTheElder commented Jan 16, 2019 via email

@fabriziopandini
Copy link
Member

@BenTheElder @neolit123 we currently support n>1 workers only.
I will send asap a PR for supporting n>1 control-plane nodes (with external LB) which is P0 for kubeadm, while external-etcd IMO is a lower priority.
And after this IMO we can focus on UX

yankay pushed a commit to yankay/kind that referenced this pull request Mar 17, 2022
internal traffic policy changes in kpng server
stg-0 pushed a commit to stg-0/kind that referenced this pull request Sep 6, 2023
* Add Azure file CSI driver

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binary release cadence
5 participants