Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support kube-proxy nftables mode #3577

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Apr 11, 2024

/hold

wait until 1.31 graduates it to beta

Fixes: #3434

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 11, 2024
@aojea
Copy link
Contributor Author

aojea commented Apr 11, 2024

/cc @danwinship

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 11, 2024
@aojea
Copy link
Contributor Author

aojea commented Apr 13, 2024

@BenTheElder the problem with this option is to keep compatibility with old version, as it only will work with new versions ... I can't remember if we have some precedent like this

@BenTheElder
Copy link
Member

@BenTheElder the problem with this option is to keep compatibility with old version, as it only will work with new versions ... I can't remember if we have some precedent like this

This is true with feature gates, not exactly the same as those are totally user supplied strings.

Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we will need to internally version-check at cluster config time anyhow and enable NFTablesProxyMode feature gate? Or do we expect the user to do this?

It's new that we have our own config option for an alpha feature.

@danwinship
Copy link
Contributor

It's new that we have our own config option for an alpha feature.

no, you missed:

wait until 1.31 graduates it to beta

@BenTheElder
Copy link
Member

Sorry, yes, SGTM.

I think we should just document that it's 1.31+, we allow clusters with mixed versions and only advanced users will be setting this field anyhow.

@aojea
Copy link
Contributor Author

aojea commented Apr 19, 2024

/hold cancel

K/K PR is already merged and this will allow to set up CI without having to use additional scripting kubernetes/kubernetes#124383

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2024
@danwinship
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3e74ca5 into kubernetes-sigs:main Apr 19, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow kubeProxyMode: "nftables" in the networking configuration
4 participants